This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Merged
Conversation
* Handle nginx responses when pmm-managed is down. * Fail if username is given. * Fix TLS certificate check. * Allow to disable TLS certificate check.
* PMM-7627 remove fossa's badge * PMM-7627 remove deprecated logs * PMM-7627 sort out keys in json * PMM-7627 put clickhouse-server.err.log back * PMM-7627 update 3rd party integration tokens * PMM-7627 rotate integration token * PMM-7627 update travis.yml to match upstream * PMM-7627 remove ch server error log
* PMM-7627 remove fossa's badge * PMM-7627 remove deprecated logs * PMM-7627 sort out keys in json * PMM-7627 put clickhouse-server.err.log back * PMM-7627 update 3rd party integration tokens * PMM-7627 rotate integration token * PMM-7627 update travis.yml to match upstream * PMM-7627 remove ch server error log * PMM-7627 update the README
* Fix external service tests * Better naming Co-authored-by: Alex Tymchuk <alexander.tymchuk@percona.com>
|
|
| @@ -0,0 +1,27 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
It seems that we can remove this file.
Contributor
Author
There was a problem hiding this comment.
Are u sure? In this repo it is unusued, but it is used in makefile, it can be maybe used in some jenkins pipeline
| @@ -0,0 +1,39 @@ | |||
| --- | |||
api-tests/.travis.yml
Outdated
| @@ -0,0 +1,49 @@ | |||
| dist: bionic | |||
Contributor
There was a problem hiding this comment.
And this one, we need to move this jobs to the main CI
api-tests/go.mod
Outdated
| @@ -0,0 +1,29 @@ | |||
| module github.com/Percona-Lab/pmm-api-tests | |||
Contributor
There was a problem hiding this comment.
Do we need separate modules configuration for tests?
Contributor
Author
There was a problem hiding this comment.
Yes, I think it's better to keep own go module for each "micro-service". API tests are standalone. We don't need dependencies from API tests inside pmm-managed.
oter
reviewed
Jul 30, 2021
puneet0191
approved these changes
Aug 18, 2021
oter
approved these changes
Aug 18, 2021
artemgavrilov
approved these changes
Aug 18, 2021
Contributor
artemgavrilov
left a comment
artemgavrilov
left a comment
There was a problem hiding this comment.
Besides missing CI looks good to me.
percona-csalguero
approved these changes
Aug 18, 2021
BupycHuk
approved these changes
Aug 18, 2021
| @@ -0,0 +1,27 @@ | |||
| --- | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command used:
TBD: FB