Conversation
ademidoff
commented
Apr 23, 2026
| && rm -rf /var/cache/* | ||
|
|
||
| RUN groupadd -g 1002 pmm-agent && \ | ||
| useradd -u 1002 -r -g pmm-agent -s /sbin/nologin \ |
Member
Author
There was a problem hiding this comment.
This is useless for UIDs above 1000 and it produces a warning.
ademidoff
commented
Apr 23, 2026
| # Configure pg_hba.conf for password authentication from all hosts (dev environment only) | ||
| # Note: In dev, we allow both trust and scram-sha-256 for convenience | ||
| "echo 'host all all 0.0.0.0/0 trust' >> /srv/postgres14/pg_hba.conf", | ||
| "echo 'host all all 0.0.0.0/0 scram-sha-256' >> /srv/postgres14/pg_hba.conf", |
Member
Author
There was a problem hiding this comment.
Since we added scram-sha-256, this was missed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5290 +/- ##
==========================================
- Coverage 47.78% 42.05% -5.74%
==========================================
Files 410 410
Lines 41992 41992
==========================================
- Hits 20066 17658 -2408
- Misses 19948 22547 +2599
+ Partials 1978 1787 -191
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <copilot@github.com>
ademidoff
commented
Apr 23, 2026
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Run Merge Gatekeeper |
Member
Author
There was a problem hiding this comment.
Upstream used to rebuild the image on every run, which was a waste.
ademidoff
requested review from
JiriCtvrtka and
maxkondr
and removed request for
a team
maxkondr
approved these changes
Apr 24, 2026
JiriCtvrtka
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-7
Link to the Feature Build: SUBMODULES-4320
This pull request introduces several improvements and fixes across the development environment, CI/CD workflows, and build configurations. The most notable changes involve updating test coverage collection to be per-package, enhancing the GitHub Actions merge gatekeeper workflow for better container registry integration, and refining Dockerfile and RPM packaging configurations for improved security and maintainability.
CI/CD and Build Process Improvements:
pull_request_targettrigger, enabled package read permissions, and switched to running the gatekeeper via a container image from GitHub Container Registry with explicit login.Makefiles (admin/Makefile,agent/Makefile,managed/Makefile,vmproxy/Makefile) to collect per-package coverage instead of cross-package coverage, simplifying the coverage process and potentially making results more accurate for each package. [1] [2] [3] [4]Development Environment Configuration:
.devcontainer/setup.pyto allow bothtrustandscram-sha-256authentication methods from all hosts for easier development, improving flexibility for local testing.Docker and Packaging Adjustments:
build/docker/server/Dockerfile.el9, switched cache mount points for DNF/YUM, ensuredmicrodnfis removed after installingdnf, and adjusted build steps for better caching and image cleanliness.build/docker/client/Dockerfile.el9, removed the redundant-rflag from theuseraddcommand forpmm-agent, as the user is not a system user.pmm-managed.spec) torootinstead ofpmm, increasing security of installed files.Note
The test failures are unrelated to this PR, they probably originate from new releases of MySQL.