PG-1237: Fixing warnings on the postgres side #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
changed the title
dAdAbird
approved these changes
Dec 5, 2024
Comment on lines
19
to
25
| if percona_ext == true | ||
| # link_with | ||
| endif |
Collaborator
Author
There was a problem hiding this comment.
forgot to do it properly, fixed
This also modifies the pg_waldump build so it is now correctly uses pg_tde as a static library, to handle warnings and custom flags for KMIP correctly. This commit also enables generic -Werror for meson builds, so that we are forced to fix warnings before merging in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also modifies the pg_waldump build so it is now correctly uses pg_tde as a static library, to handle warnings and custom flags for KMIP correctly.
This commit also enables generic -Werror for meson builds, so that we are forced to fix warnings before merging in the future.