Disable pg_tde tests when running full test suite with a global TDE config plus clean up Github scripts
#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The meson and the make scripts had diverged a lot, so this commit fixes that plus some other inconsistencies.
The TDE_MODE environment variable disables tests we actually want to run in our Github Actions. This change is also necessary to in a future commit disable the pg_tde tests in the global TDE mode.
The purpose of the global TDE mode is to run PostgreSQL's normal test suite but with our extension so running the pg_tde test suite when in that mode makes no sense. Meson supports disabling test suites with --no-suite so we only need to do this for the Makefile.
Now that we no longer run the pg_tde suite in the global TDE mode we can remove all the code which was there to support it.
jeltz
changed the title
jeltz
changed the title
pg_tde tests when running full test suite with a global TDE config plus clean up Github scripts
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (78.34%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #268 +/- ##
==================================================
Coverage 78.34% 78.34%
==================================================
Files 22 22
Lines 2484 2484
Branches 391 391
==================================================
Hits 1946 1946
Misses 462 462
Partials 76 76
🚀 New features to boost your workflow:
|
dutow
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure the normal test actions runs PostgreSQL's tests plus our
pg_tdetests while the actions which runs the tests with the global configuration sets theTDE_MODEenvironment variable which disables thepg_tdetest suite plus a couple of PostgreSQL's tests which are broken withpg_tdeenabled.In addition I noticed when trying to implement this that our Meson vs make actions had diverged so tried to harmonize them so they have the same features and similar code.
Question: since Meson supports skipping test suites with
--no-suiteI did not add skipping of the pg_tde tests tomeson.build. Right? Wrong?