✨ Add hidden CLI app command for future SDKs#1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
We are currently working on support for native app screenshots, in which the browser download normally done by the
execcommand is wholly unnecessary. With the newskipDiscoveryoption introduced with #1038, we could map a flag or environment variable to enable this option, however there might still be future difference we wish to separate by means of an entirely new CLI command namespace.This PR introduces that new namespace,
percy app. Currently all subcommands are very thin wrappers for theexeccommands which enablesskipDiscoverywhile changing the commands help output description slightly. The plan is for native apps to usepercy app:execinstead ofpercy exec(and similarly withapp:exec:start).Currently, this PR uses a
hiddencommand warning since it isn't ready to be used by any SDKs (there currently isn't any native app SDKs to support). Once we ship an SDK that utilizes these new commands, we can release a separate CLI update to unhide these commands and remove the warning.