🐛 cloneNode ensure shallow clone #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarsault
changed the title
itsjwala
reviewed
Apr 7, 2023
itsjwala
reviewed
Apr 9, 2023
itsjwala
reviewed
Apr 10, 2023
itsjwala
approved these changes
Apr 10, 2023
Contributor
|
This is related to some frameworks causing these callbacks to be triggered, currently patching on our side only seems to be the fastest option. though I'd like DOM APIs to support a parameter in the callback that makes it aware of cloning in general. |
itsjwala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebComponents have lifecycle callbacks which can mess up the structure of the page while trying to create a clone. We'd earlier fixed it for
connectedCallbackanddisconnectedCallbackin #1185.attributeChangedCallbackis called beforeconnectedCallbackand can also cause side effects when we clone a node. We solve for this effect by asserting the shallowness of the node cloned in this PR