This repository was archived by the owner on Jun 5, 2026. It is now read-only.
fix: Config array merging - #391
Merged
Merged
Conversation
djones
pushed a commit
that referenced
this pull request
Oct 4, 2019
## [0.18.3](v0.18.2...v0.18.3) (2019-10-04) ### Bug Fixes * 🐛 Config array merging ([#391](#391)) ([1574631](1574631))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
By default, the
deepmergepackage will merge nested arrays. When merging default options with overrides, this had the effect of merging default widths with user-defined widths.Approach
Pass an
arrayMergeoption that will overwrite default arrays with new arrays instead of merging them.Added a
widthsoption to our test config to verify that we should only see375and1200widths and not also default1280widths. Due to this, all of our snapshots have a new width that needs to be approved.