Skip to content

added region changes#54

Merged
amandeepsingh333 merged 10 commits intomainfrom
PPLT_3811
Apr 4, 2025
Merged

added region changes#54
amandeepsingh333 merged 10 commits intomainfrom
PPLT_3811

Conversation

@amandeepsingh333
Copy link
Copy Markdown
Contributor

@amandeepsingh333 amandeepsingh333 commented Mar 24, 2025 •
edited
Loading

adding region changes - helper function, readme, tests
updated cli to 1.30.9

usage example

obj1 = {
  "elementSelector": {
    "elementCSS": ".ad-banner" 
  },
  "algorithm": "intelliignore",
  "configuration": {
    "diffSensitivity": 2,
    "imageIgnoreThreshold": 0.2,
    "carouselsEnabled": true,
    "bannersEnabled": true,
    "adsEnabled": true
  },
  "assertion": {
    "diffIgnoreThreshold": 0.4,
  }
};

percy_snapshot(page, name="Homepage", regions: [obj1]);

@amandeepsingh333 amandeepsingh333 requested a review from a team as a code owner March 24, 2025 04:55
@amandeepsingh333 amandeepsingh333 force-pushed the PPLT_3811 branch 2 times, most recently from 01c99eb to 4f643b4 Compare March 24, 2025 10:40
pankaj443
pankaj443 reviewed Apr 3, 2025
View reviewed changes
Comment thread README.md Outdated
- `elementXpath` (string): The XPath selector for the element.
- `elementCSS` (string): The CSS selector for the element.

- `padding` (optional)
Copy link
Copy Markdown

@pankaj443 pankaj443 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik this is currently not implemented, should we not include it in readme & docs?

Copy link
Copy Markdown

@pankaj443 pankaj443 Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for other SDKs as well

this-is-shivamsingh
this-is-shivamsingh reviewed Apr 4, 2025
View reviewed changes
Comment thread percy/screenshot.py Outdated
Comment on lines +64 to +65
# pylint: disable=too-many-arguments
# pylint: disable=too-many-branches
Copy link
Copy Markdown

@this-is-shivamsingh this-is-shivamsingh Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Have it single comment

@amandeepsingh333 amandeepsingh333 merged commit 16045d2 into main Apr 4, 2025
9 checks passed
@amandeepsingh333 amandeepsingh333 deleted the PPLT_3811 branch April 4, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pankaj443 pankaj443 pankaj443 approved these changes

@this-is-shivamsingh this-is-shivamsingh this-is-shivamsingh approved these changes

@ninadbstack ninadbstack Awaiting requested review from ninadbstack ninadbstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amandeepsingh333 @pankaj443 @this-is-shivamsingh