Skip to content

🐛 Pass snapshot options along in POST request#7

Merged
Robdel12 merged 2 commits intomainfrom
rd/fix-snapshot-options
Aug 27, 2021
Merged

🐛 Pass snapshot options along in POST request#7
Robdel12 merged 2 commits intomainfrom
rd/fix-snapshot-options

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

What is this?

This is a glaring miss! When building this SDK, I forgot to pass the rest of the snapshot options on when POSTing the data to the @percy/core server.

@Robdel12 Robdel12 added the 🐛 bug Something isn't working label Aug 27, 2021
@Robdel12 Robdel12 requested a review from wwilsman August 27, 2021 17:39
This is a glaring miss! My bad..
@Robdel12 Robdel12 force-pushed the rd/fix-snapshot-options branch 2 times, most recently from 0dc7ce7 to 72fb16c Compare August 27, 2021 17:46
Copy link
Copy Markdown

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 force-pushed the rd/fix-snapshot-options branch from 72fb16c to 67d418b Compare August 27, 2021 17:49
@Robdel12 Robdel12 merged commit 4154ccb into main Aug 27, 2021
@Robdel12 Robdel12 deleted the rd/fix-snapshot-options branch August 27, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants