[codex] fix admin server protocol validation#34
Merged
web-ppanel merged 1 commit intoperfect-panel:mainfrom Apr 11, 2026
Merged
Conversation
✅ Deploy Preview for ppane-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
web-ppanel
approved these changes
Apr 10, 2026
Contributor
web-ppanel
left a comment
There was a problem hiding this comment.
The changes look correct and well thought out:
- Auto-expanding protocol sections on toggle is a good UX improvement to surface required fields immediately
- Marking required fields with
*provides clear visual feedback - Validating required fields before submission prevents silent failures
- Filtering by
enabledstatus rather than numeric port value is more robust logic
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the server protocol edit flow so enabled protocols immediately expose their required configuration and submission validates those required values before saving.
What Changed
*in the form UIRoot Cause
The protocol toggle only flipped
enableand did not drive the form UI or validation rules. As a result, required fields likeportwere easy to miss, and submit logic filtered by numeric port instead of validating enabled protocol configuration explicitly.Validation
bun --filter ppanel-admin-web checkbun --filter ppanel-admin-web build