processFilelog: improve compatibility with encoding=="raw"#3
Merged
ppiorunski merged 1 commit intoperforce:masterfrom Jun 9, 2022
rtollert:filelog-raw
Merged
processFilelog: improve compatibility with encoding=="raw"#3ppiorunski merged 1 commit intoperforce:masterfrom rtollert:filelog-raw
ppiorunski merged 1 commit intoperforce:masterfrom
rtollert:filelog-raw
Conversation
`p4 filelog` may truncate changelist descriptions in multibyte encodings. Setting p4.encoding = "raw" appears to be an effective workaround, but p4.run_filelog() breaks under raw encoding, because processFilelog() assumes the revision object contains strs. This is simple enough to fix. Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
Contributor
|
Thank you for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p4 filelogmay truncate changelist descriptions in multibyte encodings.Setting p4.encoding = "raw" appears to be an effective workaround, but
p4.run_filelog() breaks under raw encoding, because processFilelog() assumes
the revision object contains strs. This is simple enough to fix.
Signed-off-by: Richard Tollerton rich.tollerton@ni.com