Merged
Conversation
blms
reviewed
Apr 9, 2026
Contributor
blms
left a comment
There was a problem hiding this comment.
Looks good! I'm seeing a bit of what looks like repeated code between Map and CertaintyLayer where the circles are built and stored in the features array—any way that we could make that more DRY in case something needs to change later on? Fine if that's too much effort or there's a reason we can't.
Contributor
Author
|
Oops, I DRYed it out yesterday afternoon but forgot to check in my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
getFeatureshelper function with the (optional) ability to get properties data from a custom path on the record objectgeometryCertaintyLayercomponent that renders the certainty radii on the mapSourcecomponent it relies on seems to rely on the existence of a React context that doesn't exist in Peripleo (which CDP uses)