Skip to content

Fuzzy places#575

Merged
camdendotlol merged 3 commits intomasterfrom
cm/fuzzy-points
Apr 9, 2026
Merged

Fuzzy places#575
camdendotlol merged 3 commits intomasterfrom
cm/fuzzy-points

Conversation

@camdendotlol
Copy link
Copy Markdown
Contributor

@camdendotlol camdendotlol commented Apr 8, 2026

Summary

This PR:

  • adds some helper functions for generating features with circle geometry for fuzzy points
  • updates the Typesense getFeatures helper function with the (optional) ability to get properties data from a custom path on the record object
    • this is so we can support properties on related records, as with geometry
  • adds a new CertaintyLayer component that renders the certainty radii on the map
    • this only ended up being used in Core Data, as the Source component it relies on seems to rely on the existence of a React context that doesn't exist in Peripleo (which CDP uses)

@camdendotlol camdendotlol requested a review from blms April 9, 2026 16:20
Copy link
Copy Markdown
Contributor

@blms blms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm seeing a bit of what looks like repeated code between Map and CertaintyLayer where the circles are built and stored in the features array—any way that we could make that more DRY in case something needs to change later on? Fine if that's too much effort or there's a reason we can't.

@camdendotlol
Copy link
Copy Markdown
Contributor Author

camdendotlol commented Apr 9, 2026

Oops, I DRYed it out yesterday afternoon but forgot to check in my changes.

@camdendotlol camdendotlol requested a review from blms April 9, 2026 18:34
Copy link
Copy Markdown
Contributor

@blms blms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@camdendotlol camdendotlol merged commit c9d0f2b into master Apr 9, 2026
@camdendotlol camdendotlol deleted the cm/fuzzy-points branch April 9, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants