Check npm install exit code before running node scripts#192
Merged
Conversation
npm install output was piped through tail -1 to keep run logs clean, but this silently swallowed errors. When npm fails (e.g. missing packages, network issues inside containers), the script proceeds to node which crashes on missing modules with no diagnostic context. Capture npm output, check the exit code, and show full output only on failure. On success, still show just the summary line. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
k-rister
approved these changes
Jun 12, 2026
k-rister
left a comment
k-rister
left a comment
Contributor
There was a problem hiding this comment.
Anything interesting about why it failed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tail -1to keep logs clean, but this silently swallows errorsContext
Discovered via agentic-perf automated benchmark run (PERF-D095E672): fio benchmark completed successfully but OpenSearch indexing failed with "Cannot find module 'piscina'" — npm install had failed silently inside the crucible controller container.
Test plan
add-run.shwith valid node_modules — should show one-line summary as beforeadd-run.sh— should show full npm error and exit non-zero🤖 Generated with Claude Code