waveshare2in13v3/waveshare2in13v4: adding v3 and v4 waveshare 2.13" ePaper displays #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x86ed
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
+ Coverage 49.5% 51.1% +1.6%
=======================================
Files 90 99 +9
Lines 11736 12728 +992
=======================================
+ Hits 5808 6500 +692
- Misses 5674 5958 +284
- Partials 254 270 +16 ☔ View full report in Codecov by Sentry. |
|
v4 works great (v3 not tested, no v3 display...)! thanks! |
Member
|
I forgot to comment here, can you fix the linter errors? You'll need to rebase. |
Contributor
Author
|
rerunning |
Remove unreferenced, unexported values.
Remove unreferenced, unexported constants.
Contributor
|
@maruel I've fixed the outstanding lint issues on the. Are you OK with me merging it? |
maruel
approved these changes
Feb 10, 2025
Member
maruel
left a comment
maruel
left a comment
There was a problem hiding this comment.
Thanks! It's really appreciated.
gsexton
added a commit
to gsexton/devices
that referenced
this pull request
Feb 15, 2025
…Paper displays (periph#65) * adding v3 and v4 waveshare * updating file * Update waveshare213v4.go Remove unreferenced, unexported values. * Update waveshare213v3.go Remove unreferenced, unexported constants. --------- Co-authored-by: gsexton <georges@mhsoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't have a specific issue.
new functionality (if relevant).