Skip to content

Conversation

@gsexton
Copy link
Contributor

@gsexton gsexton commented Dec 7, 2024

No description provided.

@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 82.70270% with 64 lines in your changes missing coverage. Please review.

Project coverage is 49.4%. Comparing base (7fd42d5) to head (890d624).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hdc302x/hdc302x.go 82.7% 43 Missing and 21 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #83     +/-   ##
=======================================
+ Coverage   48.4%   49.4%   +1.1%     
=======================================
  Files         89      90      +1     
  Lines      11351   11721    +370     
=======================================
+ Hits        5490    5794    +304     
- Misses      5629    5674     +45     
- Partials     232     253     +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow really cool! Thanks!

Dang the check failure in https://github.com/periph/devices/actions/runs/12216048416/job/34078745883?pr=83 is real but it's totally unrelated to your change. It's a data race in driver scd4x. Filed #84

@gsexton
Copy link
Contributor Author

gsexton commented Dec 7, 2024

Wow really cool! Thanks!

Dang the check failure in https://github.com/periph/devices/actions/runs/12216048416/job/34078745883?pr=83 is real but it's totally unrelated to your change. It's a data race in driver scd4x. Filed #84

We crossed paths. The same race was happening in this branch. Also, there was a general race condition in the logic of the test that I found while doing hdc302x, so I fixed it in scd4x.

@maruel maruel merged commit 72857e8 into periph:main Dec 7, 2024
10 checks passed
@gsexton gsexton deleted the hdc302x branch March 28, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants