Skip to content

Conversation

@timlegge
Copy link
Contributor

Some SPs look at the datetime of the AuthnStatement - when the original authentication occurred at the Identity Provider.

It is likely that we should also have a AuthnStatement_valid to check whether the date is withing some SP specified timeframe.

@timlegge timlegge force-pushed the authnstatement branch 2 times, most recently from 942189e to 4c381b1 Compare April 23, 2023 15:19
@timlegge
Copy link
Contributor Author

Not sure its complete yet or even if this is the correct approach. @waterkip you may have some suggestions.

@timlegge timlegge changed the title Authnstatement as an object Draft: Authnstatement as an object Apr 23, 2023
@timlegge timlegge requested a review from waterkip April 23, 2023 15:32
@timlegge timlegge force-pushed the authnstatement branch 2 times, most recently from 44089e9 to ea451bf Compare April 23, 2023 16:19
@waterkip
Copy link
Collaborator

I think we may want to make a Net::SAML2::AuthStatement object that you can query instead of doing it via the assertion. I'm a little bit opposed to the authstatment_foobar calls. It feels we either need to have an object there or we need to call them just foobar.

@timlegge
Copy link
Contributor Author

I think we may want to make a Net::SAML2::AuthStatement object that you can query instead of doing it via the assertion. I'm a little bit opposed to the authstatment_foobar calls. It feels we either need to have an object there or we need to call them just foobar.

Pretty much just following the nameid changes you did a while ago. I am not really happy with the authnstatement_whatever calls either. Since it is a subsection of the assertion I would be more inclined to populate the assertion with the data.

@waterkip waterkip changed the title Draft: Authnstatement as an object Authnstatement as an object Jul 3, 2023
@waterkip waterkip merged commit b672a6e into perl-net-saml2:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants