Merge xml sig changes from upstream #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlegge
force-pushed
the
merge-xml-sig
branch
from
9e39350 to
9546b60
Compare
timlegge
force-pushed
the
merge-xml-sig
branch
from
9546b60 to
191beb6
Compare
timlegge
force-pushed
the
merge-xml-sig
branch
from
191beb6 to
91208a2
Compare
timlegge
commented
Jan 13, 2021
Contributor
Author
timlegge
left a comment
timlegge
left a comment
There was a problem hiding this comment.
Looks fine at this point I have worked through a number of issues in XML::Sig and it fixes a number of underlying issue in the previous version. Time to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::SAML now considers XML::Sig to be the upstream version and will rebase when needed. Likely in the near future we will drom Net::SAML::XML::Sig and use XML::Sig since we are able to maintain it