Skip to content

Change transaction fee and reward calculations.#239

Merged
rkeene merged 10 commits intomasterfrom
transaction-fee-and-rewards
Oct 1, 2019
Merged

Change transaction fee and reward calculations.#239
rkeene merged 10 commits intomasterfrom
transaction-fee-and-rewards

Conversation

@a-urth
Copy link
Contributor

@a-urth a-urth commented Sep 25, 2019

#232 #233

Also changed naming for collapse_test

Copy link
Contributor

@AhmadMuzakkir AhmadMuzakkir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me after some testing. A few issues remain:

  1. The total reward may not be exactly the same as the total fee (though the total reward will never exceed the total fee, so it is not a huge deal)
  2. There is no test that verifies that withdrawal requests work -- we did this experimentally and it worked. There is no test because in older versions it was harder to get the reward triggered, but now it is deterministic.

@rkeene rkeene merged commit 1d1e27a into master Oct 1, 2019
@iwasaki-kenta iwasaki-kenta deleted the transaction-fee-and-rewards branch October 17, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants