Skip to content

Ignore tx error caused by adding transactions with too low depth#243

Merged
rkeene merged 11 commits intomasterfrom
fix-download-missing-tx
Oct 1, 2019
Merged

Ignore tx error caused by adding transactions with too low depth#243
rkeene merged 11 commits intomasterfrom
fix-download-missing-tx

Conversation

@hasyimibhar
Copy link
Contributor

@hasyimibhar hasyimibhar commented Sep 27, 2019

If a transaction depth is too low due to pruning, the transaction is now ignored.

@hasyimibhar
Copy link
Contributor Author

This PR implements Ledger.Close. I created PR #244 specifically for that (ideally we should strive so that each PR only does 1 thing), so make sure that PR gets merged first. After it's merged, I will rebase this PR on top of master.

@hasyimibhar hasyimibhar changed the title [WIP] Fix download tx Ignore tx error caused by adding transactions with too low depth Oct 1, 2019
@rkeene rkeene self-requested a review October 1, 2019 12:15
@rkeene rkeene merged commit ca9ee94 into master Oct 1, 2019
@rkeene rkeene mentioned this pull request Oct 1, 2019
@iwasaki-kenta iwasaki-kenta deleted the fix-download-missing-tx branch October 17, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants