Add event batching to hb_event#757
Merged
samcamwilliams merged 5 commits intoimpr/gunfrom Mar 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process increment events in batches and reduces the amount of querying the mailbox size.
Two benchmarks included and a correctness test to check that batching did not break event counters.
Original problem (there is a benchmark/test showing it): We are unable to drain fast enough and it gets slow as the mailbox grows, up to a point where it cant keep up. That point is far from the limits we have configured, so the alternative to this PR is setting it to 5MB (currently 1GB). That is not necessary with this PR as we can drain 1GB instantly.