fix: token -> pot subject body to outter hoisting #828
Merged
charmful0x merged 6 commits intofix/circular-delegationfrom Apr 9, 2026
Merged
fix: token -> pot subject body to outter hoisting #828charmful0x merged 6 commits intofix/circular-delegationfrom
subject body to outter hoisting #828charmful0x merged 6 commits intofix/circular-delegationfrom
Conversation
charmful0x
changed the title
subject body to outter hoisting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes a bug where the token device reads the mint
Subjectfrom request's Body, and fwd'd the request as is to the~pot@1.0device.the issue is, the pot device reads the
Subjectfrom the request top level instead of body, thereforedev_pot:mint/3will always default to<<"global">>dripping instead of subject'd mint.The fix hoists
body.subjectto the top level request in dev_token before dispatching to dev_potalso added tests in dev_token_pot_test_vectors