dan/per-10356-add-incremental-updates-to-the-factstore#169
Merged
danyi1212 merged 7 commits intoexternal-data-sourcefrom Aug 29, 2024
Merged
Conversation
asafc
approved these changes
Aug 26, 2024
Contributor
asafc
left a comment
asafc
left a comment
There was a problem hiding this comment.
overall looks ok - a few minor issues
asafc
approved these changes
Aug 28, 2024
Contributor
asafc
left a comment
asafc
left a comment
There was a problem hiding this comment.
approved with comment (1 blocker)
Contributor
Author
|
Still missing the delete operations |
asafc
reviewed
Aug 29, 2024
Contributor
asafc
left a comment
asafc
left a comment
There was a problem hiding this comment.
it's still ok - but you did not fix my previous blocking comment about tenant in resource role assignment and i am not sure about the logic of "update user" and "update instance" becomes delete. is this because we are using PUT? if so? where are the comments that explain it?
asafc
approved these changes
Aug 29, 2024
Contributor
asafc
left a comment
asafc
left a comment
There was a problem hiding this comment.
please add comments where i requested
omer9564
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Added data manager policy store * Added missing arguments for OpaClient * Added forwarding facts to data manager * Changed to new facts schema * Changed policy store to use new data update API * Added delete operations for inplace updates * Added comments about delete operations
omer9564
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Added data manager policy store * Added missing arguments for OpaClient * Added forwarding facts to data manager * Changed to new facts schema * Changed policy store to use new data update API * Added delete operations for inplace updates * Added comments about delete operations
omer9564
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Added data manager policy store * Added missing arguments for OpaClient * Added forwarding facts to data manager * Changed to new facts schema * Changed policy store to use new data update API * Added delete operations for inplace updates * Added comments about delete operations
omer9564
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Added data manager policy store * Added missing arguments for OpaClient * Added forwarding facts to data manager * Changed to new facts schema * Changed policy store to use new data update API * Added delete operations for inplace updates * Added comments about delete operations
danyi1212
deleted the
dan/per-10356-add-incremental-updates-to-the-factstore
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.