Merged
Conversation
Ensure the script pulls the latest changes from the `permit-opa` repository before creating the custom OPA tarball. Added a success message to confirm tarball creation.
omer9564
reviewed
Apr 24, 2025
omer9564
approved these changes
Apr 27, 2025
Contributor
omer9564
left a comment
omer9564
left a comment
There was a problem hiding this comment.
Approved, some of the suggestion are still relevant but can be done or moved into a separate ticket
danyi1212
added a commit
that referenced
this pull request
May 13, 2025
* Added Rust PDP * Update build script to pull latest changes and add logs Ensure the script pulls the latest changes from the `permit-opa` repository before creating the custom OPA tarball. Added a success message to confirm tarball creation. * Fixed linting errors * Renamed pdp crate to pdp-server * Removed duplicate authn middleware for tests * Refactor the PDP engine structure * Added watchdog crate * Added restart channel * Added graceful shutdown and term timeout * Add ServiceWatchdog with health checking capabilities * Changed app state to use ServiceWatchdog instead of PDP Engine * Remove example code * Changed Dockerfile to use new Rust PDP * Improve path handling in horizon fallback and add test for unmatched 404 response
danyi1212
added a commit
that referenced
this pull request
Jun 8, 2025
* Added Rust PDP * Update build script to pull latest changes and add logs Ensure the script pulls the latest changes from the `permit-opa` repository before creating the custom OPA tarball. Added a success message to confirm tarball creation. * Fixed linting errors * Renamed pdp crate to pdp-server * Removed duplicate authn middleware for tests * Refactor the PDP engine structure * Added watchdog crate * Added restart channel * Added graceful shutdown and term timeout * Add ServiceWatchdog with health checking capabilities * Changed app state to use ServiceWatchdog instead of PDP Engine * Remove example code * Changed Dockerfile to use new Rust PDP * Improve path handling in horizon fallback and add test for unmatched 404 response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.