Add CONTROL_PLANE_TIMEOUT configuration and apply it across various components #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danyi1212
commented
Sep 14, 2025
danyi1212
commented
- Introduced CONTROL_PLANE_TIMEOUT setting in SidecarConfig for controlling request timeouts.
- Updated aiohttp ClientSession and AsyncClient to utilize the new timeout configuration.
- Modified BlockingRequest to accept a timeout parameter, ensuring consistent timeout handling in blocking requests.
- Adjusted RemoteConfigFetcher and EnvApiKeyFetcher to incorporate the timeout setting for improved request management.
…omponents - Introduced CONTROL_PLANE_TIMEOUT setting in SidecarConfig for controlling request timeouts. - Updated aiohttp ClientSession and AsyncClient to utilize the new timeout configuration. - Modified BlockingRequest to accept a timeout parameter, ensuring consistent timeout handling in blocking requests. - Adjusted RemoteConfigFetcher and EnvApiKeyFetcher to incorporate the timeout setting for improved request management.
omer9564
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.