Skip to content

Support include total count for listing roles and resources#97

Merged
RazcoDev merged 5 commits intopermitio:mainfrom
teofilomonteiro:support-include-total-count
Sep 27, 2024
Merged

Support include total count for listing roles and resources#97
RazcoDev merged 5 commits intopermitio:mainfrom
teofilomonteiro:support-include-total-count

Conversation

@teofilomonteiro
Copy link
Copy Markdown
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

add the possibility of listing resources with total count

  • What is the current behavior? (You can also link to an open issue here)

no total count is available

  • What is the new behavior (if this is a feature change)?

  • Other information:

This pull request introduces enhancements to the pagination functionality in the API, particularly focusing on extending pagination options to include the total count of items. The changes span across multiple files and involve updates to interfaces, type definitions, and API methods.

Pagination Enhancements:

  • src/api/base.ts: Added IBasePaginationExtended interface to include page, perPage, and includeTotalCount fields. Created IPaginationExtended type to support optional inclusion of total count.

API Resource Changes:

API Role Changes:

Copy link
Copy Markdown
Contributor

@RazcoDev RazcoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@RazcoDev RazcoDev merged commit 6317248 into permitio:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants