Support include total count for listing roles and resources#97
Merged
RazcoDev merged 5 commits intopermitio:mainfrom Sep 27, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the possibility of listing resources with total count
no total count is available
What is the new behavior (if this is a feature change)?
Other information:
This pull request introduces enhancements to the pagination functionality in the API, particularly focusing on extending pagination options to include the total count of items. The changes span across multiple files and involve updates to interfaces, type definitions, and API methods.
Pagination Enhancements:
src/api/base.ts: AddedIBasePaginationExtendedinterface to includepage,perPage, andincludeTotalCountfields. CreatedIPaginationExtendedtype to support optional inclusion of total count.API Resource Changes:
src/api/resources.ts: Updated thelistmethod inResourcesApito use the newIPaginationExtendedtype, allowing it to optionally include the total count of resources. [1] [2] [3]src/openapi/api/resources-api.ts: Modified functions and interfaces to support theincludeTotalCountparameter in resource listing methods. [1] [2] [3] [4] [5] [6] [7] [8] [9]API Role Changes:
src/api/roles.ts: Updated thelistmethod inRolesApito use the newIPaginationExtendedtype, allowing it to optionally include the total count of roles. [1] [2] [3] [4]src/openapi/api/roles-api.ts: Modified functions and interfaces to support theincludeTotalCountparameter in role listing methods. [1] [2] [3] [4] [5] [6] [7] [8] [9]