Harden chart README workflow against fork PR checkout#21
Merged
perplexedmontagna merged 1 commit intoMay 18, 2026
Merged
Conversation
perplexedmontagna
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
.github/workflows/generate-chart-readme.yamlagainst the fork PRpull_request_targetcheckout issue demonstrated in #20.The workflow still updates chart README metadata for trusted same-repository PR branches, but it no longer runs as a privileged
pull_request_targetjob against fork-controlled code.Changes
pull_request_targettopull_request.github.repository, not the PR-controlledhead.repo.full_name.persist-credentials: falseso checkout credentials are not available to later steps.GITHUB_TOKENonly to the final push step, after generation is complete.actions/checkoutpinned, updated to the current v6 commit.Why this is minimal
The workflow still uses the same path trigger, generator, commit message, and README update flow for same-repo PRs. Fork-origin PRs are the only behavior removed from the privileged write path, which is the vulnerable case.
Validation
git diff --check.