-
-
Notifications
You must be signed in to change notification settings - Fork 24
Parallel tests #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Parallel tests #81
Conversation
to clear out a CI issue
revert this fix
See if pyicu changes this
…at conda and pip dont provide
…lizes tests that have race conditions, and renames tests to avoid namespace collisions
…github has py314 up in CI
|
Note that this assumes #79 went in; if not, I can retract this. |
|
Just an observation for now -- this fails if you run with tox --parallel to try to do all the envs at the same time, for the same fundamental reason -- trying to write to the same bibtex files in the same places. Also, CI is still failing since the CI changes in #79 are not yet reflected here. |
|
Note that I see that |
…ifies a clear place for a fixture(). Also, runs this entire, relativly small file through black
|
@perrette Another way I can do this is marking the relevant ones with Let me know? |
|
@perrette Similarly here, there's a couple small test improvements that I can submit over time separately -- mainly stuff that let me know... |
|
Given the state of affairs in #79, can very likely close this. |
WIP
DONTMERGE
Here, I use x-dist to run the tests in parallel over multiple cores, which should speed things up there.
One issue that emerged is that there were race conditions in the tests. I addressed this in part by putting all the conflicting ones in a a new file -- test_serial -- which then gets run serially, so the speedup is not purely over all the cores at present.
Many of the race conditions were due to writing to the temp bib file on dist directly -- I'd be glad to try to address this using pytest fixtures, which can be instantiated in parallel.
What's more interesting is that having to do this by hand showed that a few tests were note being identified at all due to namespace collisions, and were not being run, so the test count went up by a few for free.