[BUGFIX] fix variable interpolation in prometheus label value query - #675
Merged
Merged
Conversation
zhuje
force-pushed
the
ou1407-fix-label-value-endpoint-pr
branch
from
June 11, 2026 21:53
88a7df7 to
fa738e3
Compare
jgbernalp
self-requested a review
June 12, 2026 07:24
jgbernalp
reviewed
Jun 12, 2026
zhuje
force-pushed
the
ou1407-fix-label-value-endpoint-pr
branch
3 times, most recently
from
June 14, 2026 21:54
9e06aa0 to
0df8bac
Compare
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
force-pushed
the
ou1407-fix-label-value-endpoint-pr
branch
from
June 15, 2026 14:16
fba49b0 to
a1048ec
Compare
jgbernalp
reviewed
Jun 15, 2026
zhuje
force-pushed
the
ou1407-fix-label-value-endpoint-pr
branch
from
June 15, 2026 19:23
46e862e to
986e54d
Compare
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
requested changes
Jun 16, 2026
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
…tion Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
jgbernalp
reviewed
Jun 16, 2026
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
force-pushed
the
ou1407-fix-label-value-endpoint-pr
branch
from
June 16, 2026 15:40
06bc247 to
9f263e8
Compare
jgbernalp
approved these changes
Jun 16, 2026
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current (Broken) Format:
GET /api/v1/label/job/values?start=1781076832&end=1781080432&namespace=%24%7Bnamespace%3Aqueryparam%7DWhere
%24%7Bnamespace%3Aqueryparam%7Dis URL-encoded ${namespace:queryparam} (the raw, uninterpolated variable)Expected (Fixed) Format:
GET /api/v1/label/job/values?start=1781076832&end=1781080432&namespace=a&namespace=b&namespace=c&namespace=dWhere the namespace parameter is repeated for each selected value in the multi-select variable, just like the working query_range requests.
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes