Skip to content

[BUGFIX] fix variable interpolation in prometheus label value query - #675

Merged
jgbernalp merged 8 commits into
perses:mainfrom
zhuje:ou1407-fix-label-value-endpoint-pr
Jun 17, 2026
Merged

[BUGFIX] fix variable interpolation in prometheus label value query#675
jgbernalp merged 8 commits into
perses:mainfrom
zhuje:ou1407-fix-label-value-endpoint-pr

Conversation

@zhuje

@zhuje zhuje commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Current (Broken) Format:
 GET /api/v1/label/job/values?start=1781076832&end=1781080432&namespace=%24%7Bnamespace%3Aqueryparam%7D
 Where %24%7Bnamespace%3Aqueryparam%7D is URL-encoded ${namespace:queryparam} (the raw, uninterpolated variable)

Expected (Fixed) Format:
GET /api/v1/label/job/values?start=1781076832&end=1781080432&namespace=a&namespace=b&namespace=c&namespace=d
 Where the namespace parameter is repeated for each selected value in the multi-select variable, just like the working query_range requests.

Screenshots

Screenshot 2026-06-11 at 4 58 37 PM

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • [N/A] Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

@zhuje
zhuje requested a review from a team as a code owner June 11, 2026 21:04
@zhuje
zhuje requested review from shahrokni and removed request for a team June 11, 2026 21:04
@zhuje
zhuje force-pushed the ou1407-fix-label-value-endpoint-pr branch from 88a7df7 to fa738e3 Compare June 11, 2026 21:53
@jgbernalp
jgbernalp self-requested a review June 12, 2026 07:24
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
@zhuje
zhuje force-pushed the ou1407-fix-label-value-endpoint-pr branch 3 times, most recently from 9e06aa0 to 0df8bac Compare June 14, 2026 21:54
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
@zhuje
zhuje force-pushed the ou1407-fix-label-value-endpoint-pr branch from fba49b0 to a1048ec Compare June 15, 2026 14:16
@zhuje
zhuje requested a review from jgbernalp June 15, 2026 14:31
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
@zhuje
zhuje force-pushed the ou1407-fix-label-value-endpoint-pr branch from 46e862e to 986e54d Compare June 15, 2026 19:23
@zhuje
zhuje requested a review from jgbernalp June 15, 2026 19:35
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
…tion

Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
Comment thread prometheus/src/plugins/PrometheusLabelValuesVariable.tsx Outdated
zhuje added 2 commits June 16, 2026 10:31
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
@zhuje
zhuje force-pushed the ou1407-fix-label-value-endpoint-pr branch from 06bc247 to 9f263e8 Compare June 16, 2026 15:40
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
@zhuje
zhuje requested a review from andreasgerstmayr as a code owner June 16, 2026 20:53
@jgbernalp
jgbernalp added this pull request to the merge queue Jun 17, 2026
Merged via the queue into perses:main with commit c8a5e7f Jun 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants