Skip to content

[ENHANCEMENT] prometheus: improve explorer filters #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gladorme merged 2 commits into from
Sep 10, 2025
Merged

[ENHANCEMENT] prometheus: improve explorer filters #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c99786
[ENHANCEMENT] prometheus: improve explorer filters
Gladorme Sep 10, 2025
9e56fa8
Apply feedbacks
Gladorme Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions prometheus/src/explore/PrometheusMetricsFinder/PrometheusMetricsFinder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,14 @@ export function MetricNameExplorer({
value={search}
onChange={(e) => setSearch(e.target.value)}
placeholder="Search metric name..."
InputProps={{
startAdornment: (
<InputAdornment position="start">
<Magnify />
</InputAdornment>
),
slotProps={{
input: {
startAdornment: (
<InputAdornment position="start">
<Magnify />
</InputAdornment>
),
},
}}
/>
<MetricList
Expand Down Expand Up @@ -186,7 +188,7 @@ export function PrometheusMetricsFinder({

// Remove duplicated filters and filters without label or labelValues
const filteredFilters: LabelFilter[] = useMemo(() => {
return filters.filter((filter) => filter.label && filter.labelValues.length > 0);
return filters.filter(({ label, labelValues }) => label && labelValues?.[0]);
}, [filters]);

const searchParams = useExplorerQueryParams({
Expand Down
14 changes: 14 additions & 0 deletions prometheus/src/explore/PrometheusMetricsFinder/filter/FilterInputs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,20 @@ export function RawFilterInput({
value={value.operator}
variant="outlined"
onChange={(event: SelectChangeEvent) => {
if (value.operator === '=' || value.operator === '!=') {
// switch from single to multiple
return onChange({ label: value.label, labelValues: [], operator: event.target.value as Operator });
}

if (value.operator === '=~' || value.operator === '!~') {
// switch from multiple to single, keep the first value if exists
return onChange({
label: value.label,
labelValues: value.labelValues.slice(0, 1),
operator: event.target.value as Operator,
});
}

onChange({ label: value.label, labelValues: value.labelValues, operator: event.target.value as Operator });
}}
size="medium"
Expand Down