Skip to content

[BUGFIX] TimeSeriesChart: migration: handle lineWidth as string#401

Merged
AntoineThebaud merged 5 commits intomainfrom
antoinethebaud/ts-fix-lineWidth
Oct 9, 2025
Merged

[BUGFIX] TimeSeriesChart: migration: handle lineWidth as string#401
AntoineThebaud merged 5 commits intomainfrom
antoinethebaud/ts-fix-lineWidth

Conversation

@AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Oct 8, 2025

Description

Fix such migration failure when lineWidth is a string: bad request: unable to convert to Perses panel: spec: invalid operands \"0\" and 3 to '>' (type string and int)

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud marked this pull request as ready for review October 8, 2025 20:18
Copy link
Contributor

@ibakshay ibakshay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AntoineThebaud AntoineThebaud added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit abc66ca Oct 9, 2025
13 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/ts-fix-lineWidth branch October 9, 2025 10:40
abelyakin pushed a commit to abelyakin/plugins that referenced this pull request Jan 14, 2026
…es#401)

* [BUGFIX] TimeSeriesChart: migration: handle lineWidth as string

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* simplify code using switch pattern

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* fix import

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* cover case in unit test

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

* remove redundant code

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>

---------

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants