Skip to content

[BUGFIX] PrometheusTimeSeriesQuery: Grafana migration: don't match non-prom queries when type is set #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntoineThebaud merged 1 commit into from
Apr 17, 2026
Merged

[BUGFIX] PrometheusTimeSeriesQuery: Grafana migration: don't match non-prom queries when type is set #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions prometheus/schemas/prometheus-time-series-query/migrate/migrate.cue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@
package migrate

#target: {
// /!\ Best-effort conversion logic that may wrongly convert not-prometheus queries to PrometheusTimeSeriesQuery:
// Ideally we should rely on datasource.type = "prometheus" to identify prometheus queries. But in some cases,
// this information is not be available. Thus the condition relies on the presence of the "expr" field, that
// likely indicates that this is a prometheus query.
datasource?: {
uid: string
type?: "prometheus"
uid: string
}
// /!\ Best-effort conversion logic that may wrongly convert not-prometheus queries to PrometheusTimeSeriesQuery:
// Ideally we should only rely on datasource.type = "prometheus" to identify prometheus queries. But in some cases,
// this information is not present. Thus, in addition to the check on the optional type above, the below condition
// relies on the presence of the "expr" field, that likely indicates that this is a prometheus query.
expr: string
legendFormat?: string
interval?: string
Expand Down
1 change: 1 addition & 0 deletions prometheus/schemas/prometheus-time-series-query/migrate/tests/legend-format/input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
},
"editorMode": "code",
Expand Down
Loading