Skip to content

[ENHANCEMENT] add client package#137

Merged
Nexucis merged 3 commits into
mainfrom
feat/create-client
May 27, 2026
Merged

[ENHANCEMENT] add client package#137
Nexucis merged 3 commits into
mainfrom
feat/create-client

Conversation

@shahrokni
Copy link
Copy Markdown
Contributor

@shahrokni shahrokni commented May 20, 2026 •
edited
Loading

Description

Adds the client package and removes the remaining core dependencies.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@shahrokni shahrokni force-pushed the feat/create-client branch 4 times, most recently from 39f0887 to b77d72b Compare May 21, 2026 10:03
@shahrokni shahrokni marked this pull request as ready for review May 21, 2026 10:05
@shahrokni shahrokni requested a review from a team as a code owner May 21, 2026 10:05
@shahrokni shahrokni requested review from jgbernalp and removed request for a team May 21, 2026 10:05
jgbernalp
jgbernalp reviewed May 22, 2026
View reviewed changes
Comment thread client/README.md Outdated
jgbernalp
jgbernalp reviewed May 22, 2026
View reviewed changes
Comment thread dashboards/package.json
jgbernalp
jgbernalp reviewed May 22, 2026
View reviewed changes
Comment thread plugin-system/src/remote/PluginRuntime.tsx
},
},
// TODO should we add @perses-dev/spec here ?
'@perses-dev/core': {
Copy link
Copy Markdown
Contributor

@jgbernalp jgbernalp May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this we need to add the client package

@jgbernalp
Copy link
Copy Markdown
Contributor

jgbernalp commented May 22, 2026

The plugin system has a duplicated definition of the DatasourceDefinition. Maybe we should search in the code if there are other occurrences of this duplicated interfaces

jgbernalp
jgbernalp reviewed May 22, 2026
View reviewed changes
Comment thread client/tsconfig.json Outdated
@shahrokni
Copy link
Copy Markdown
Contributor Author

shahrokni commented May 22, 2026 •
edited
Loading

The plugin system has a duplicated definition of the DatasourceDefinition. Maybe we should search in the code if there are other occurrences of this duplicated interfaces

I was aware of that blunder and had planned to get rid of it. Thank you for reminding me. I almost forgot!
And, this should be the only one as far as I know.

@shahrokni shahrokni requested a review from jgbernalp May 22, 2026 12:25
@shahrokni shahrokni marked this pull request as draft May 22, 2026 12:30
@shahrokni shahrokni marked this pull request as ready for review May 22, 2026 13:39
@shahrokni shahrokni force-pushed the feat/create-client branch 2 times, most recently from 4df95ba to 8d1d7f0 Compare May 22, 2026 14:03
jgbernalp
jgbernalp reviewed May 22, 2026
View reviewed changes
Comment thread plugin-system/src/remote/PluginRuntime.tsx
@shahrokni shahrokni force-pushed the feat/create-client branch from 8d1d7f0 to 6330c8b Compare May 22, 2026 15:07
@shahrokni shahrokni changed the title [ENHANCEMENT] add client package [BREAKINGCHANGE] add client package May 22, 2026
@shahrokni shahrokni changed the title [BREAKINGCHANGE] add client package [ENHANCEMENT] add client package May 22, 2026
@shahrokni shahrokni force-pushed the feat/create-client branch 2 times, most recently from ac55600 to 7577657 Compare May 22, 2026 15:13
@shahrokni shahrokni requested a review from jgbernalp May 26, 2026 08:33
Nexucis
Nexucis reviewed May 26, 2026
View reviewed changes
Comment thread client/package.json Outdated
@@ -0,0 +1,37 @@
{
"name": "@perses-dev/client",
"version": "0.1.0",
Copy link
Copy Markdown
Member

@Nexucis Nexucis May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have the same version for all packages in this repo.

Nexucis
Nexucis reviewed May 26, 2026
View reviewed changes
Comment thread plugin-system/package.json
@shahrokni
[ENHANCEMENT] add client package
97d7095 
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the feat/create-client branch from 7577657 to 97d7095 Compare May 26, 2026 17:11
shahrokni added 2 commits May 26, 2026 19:17
@shahrokni
keep the core dependecy
ebe7bba 
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni
integrate client package version
4b20e5a 
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni requested a review from Nexucis May 26, 2026 17:50
Nexucis
Nexucis approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @shahrokni, well done :)

@Nexucis Nexucis merged commit 335619a into main May 27, 2026
12 checks passed
@Nexucis Nexucis deleted the feat/create-client branch May 27, 2026 08:43
@shahrokni shahrokni mentioned this pull request May 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nexucis Nexucis Nexucis approved these changes

@jgbernalp jgbernalp Awaiting requested review from jgbernalp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shahrokni @jgbernalp @Nexucis