Skip to content

[IGNORE] add basic unit tests for the dashboard timezone#86

Merged
jgbernalp merged 1 commit intomainfrom
test/datetimepicker_unittests
Mar 10, 2026
Merged

[IGNORE] add basic unit tests for the dashboard timezone#86
jgbernalp merged 1 commit intomainfrom
test/datetimepicker_unittests

Conversation

@shahrokni
Copy link
Contributor

Description

Some basic unit tests have been added for the DateTimeRangePicker component.
These tests merely cover some timezone logic. Probably more comprehensive tests are required. (In Progress...)

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@shahrokni shahrokni requested a review from a team as a code owner March 10, 2026 10:36
@shahrokni shahrokni marked this pull request as draft March 10, 2026 10:38
@shahrokni shahrokni force-pushed the test/datetimepicker_unittests branch 2 times, most recently from 9220aa7 to 3709e73 Compare March 10, 2026 10:46
@shahrokni shahrokni requested a review from jgbernalp March 10, 2026 10:48
@shahrokni shahrokni marked this pull request as ready for review March 10, 2026 10:48
@shahrokni shahrokni changed the title [IGNORE] add unit tests for the dashboard timezone [IGNORE] add basic unit tests for the dashboard timezone Mar 10, 2026
Select Start Time
</Typography>
<StaticDateTimePicker
data-testid="select_start_time_picker"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to be used

Select End Time
</Typography>
<StaticDateTimePicker
data-testid="select_end_time_picker"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the test/datetimepicker_unittests branch from 3709e73 to e4ad55d Compare March 10, 2026 12:45
@shahrokni shahrokni requested a review from jgbernalp March 10, 2026 12:58
@jgbernalp jgbernalp merged commit e2ffac0 into main Mar 10, 2026
12 checks passed
@jgbernalp jgbernalp deleted the test/datetimepicker_unittests branch March 10, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants