Expressions API Updates#2399
Merged
texodus merged 2 commits intoperspective-dev:masterfrom Nov 11, 2023
Merged
Conversation
acb0642 to
390125c
Compare
Contributor
Author
|
|
added 2 commits
November 6, 2023 12:00
Co-authored-by: Tom Jakubowski <tom@crystae.net> Co-authored-by: Broch Stilley <brochington@gmail.com>
390125c to
1fdb553
Compare
Member
|
Thanks for the PR! I'm going to go ahead and merge this now as it looks good structurally and there is some backlog behind it. As discussed offline, I'd like to see some changes to both the UX and API before the next release:
|
texodus
approved these changes
Nov 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now specify expression columns using either an array of strings or an array of
{name: string, expr: string}objects. This allows us to more easily rename expressions and separates parsing from the string type.This API update is backwards-compatible, so plain-string expressions are still parsed correctly. Because of this I have not written any migration code.
In addition, I have removed some extra stuff from the column settings panel, including the attributes tab "type" field and the entire attributes tab if the column is not an expression.