Fix Jupyterlab Widget Save/Restore Symmetry#2465
Merged
texodus merged 1 commit intoperspective-dev:masterfrom Dec 12, 2023
Merged
Fix Jupyterlab Widget Save/Restore Symmetry#2465texodus merged 1 commit intoperspective-dev:masterfrom
texodus merged 1 commit intoperspective-dev:masterfrom
Conversation
Member
|
Thanks for the PR! Looks good! |
texodus
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2464
The version keyword should be ignored when restoring the widget, as it does not affect the widget itself. The version keyword is currently only used for migrations. Eventually, I would like to see automatic migrations based on version number, which will require a more sophisticated solution. This works for now :)