Stringify Arrow lists#2700
Merged
texodus merged 2 commits intoperspective-dev:masterfrom Aug 26, 2024
Merged
Conversation
sinistersnare
force-pushed
the
feature/arrow-list-stringify
branch
3 times, most recently
from
984295e to
43b0760
Compare
Signed-off-by: Davis Silverman <davis@thedav.is>
sinistersnare
force-pushed
the
feature/arrow-list-stringify
branch
from
43b0760 to
750a400
Compare
texodus
approved these changes
Aug 26, 2024
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, Perspective fails to load when given an arrow with a
ListArray. This PR provides minimal support for this data type by stringifying the list so it can be rendered as a string. Only a few list-element data-types are currently supported by this PR, but more can be added by this scaffolding.