Fix UI bugs from large dataset example #3022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lscreen Signed-off-by: Andrew Stein <steinlink@gmail.com>
…ddition to triggering `on_error`) Signed-off-by: Andrew Stein <steinlink@gmail.com>
…perties Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
fix-ui-large-bugs
branch
from
1c859f1 to
7afe726
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
…expect` Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
fix-ui-large-bugs
branch
from
7afe726 to
d9d0fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a set of bugs uncovered during testing of a
perspective-pythonserver-only application hosting ~10mm rows and 100 columns (of mostfloat), updating in 10k batches with 10ms delays between each batch.HTMLPerspectiveViewerElement::restorecalls to first apply and render thepluginfield, before the other fields, yielding graphical artifacts and a performance hit.maxPayload(to node), andwebsocket_max_message_sizeandmax_buffer_size(toperspective.handlers.tornado) for large messages.expressionsto be updated under draw lock, which prevents rapid expression redefinitions from being marked invalid..expect()calls in theyewrender tree which could fail in the (above) race condition, leading to anabort().handle_errorcalledClientinstances with async methods in-flight, which now throw the underlying transport error (previously they threw a generic "cancelled" error).perspective-workspacecontext menu to not open off-screen when the workspace itself is not "full screen" in the browser panel.