Fix virtual server error handling #3114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
fix-vs-errors
branch
from
581f757 to
dc7eb32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps errors returned from virtual server methods in the
ServerErrormessage, so they show up in the UI instead of the console. Passing this error on is also necessary for the one instance where<perspective-viewer>uses errors for flow control - when detecting a render has been interrupted by a newer render.In addition,
regular-talehas been updated tov0.8.0which removes some scroll jitter, and the examples have been updated to better incorporate recent API changes.