fix(create-expert): clarify demo sample data must be embedded in instruction#372
Merged
fix(create-expert): clarify demo sample data must be embedded in instruction#372
Conversation
…ruction Updated Demo Expert Template to: - Rename 'Sample Data' to 'Embedded Sample Data' with IMPORTANT note - Add example showing what embedded sample data looks like - Emphasize 'do NOT make API calls' in demo mode Closes #361
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify in the Demo Expert Template that sample data must be embedded directly in the instruction, not as placeholders.
Changes
Rationale
The previous template had
[Include relevant sample data for demonstration]which was ambiguous. This update makes it explicit that the ecosystem-builder must generate actual sample data, not placeholder text.Closes #361
🤖 Generated with Claude Code
Note
Strengthens the Demo Expert template to ensure zero-config demos use real embedded data.
apps/create-expert/src/lib/create-expert-toml.tsDemo Expert instructions: require embedded sample data (renamed to Embedded Sample Data), add an IMPORTANT note and a concrete JSON example, and emphasize “do NOT make API calls” in demo mode.changeset/clarify-demo-sample-data.mdfor a patch releaseWritten by Cursor Bugbot for commit 9c496e5. This will update automatically on new commits. Configure here.