feat: add runtimeVersion to Job schema with validation#442
Merged
Conversation
- Add `runtimeVersion: RuntimeVersion` to Job schema - Add `minRuntimeVersion?: RuntimeVersion` to Expert schema - Runtime 0.x.y is treated as v1.0 for compatibility - Validate entire delegation chain before execution (fail fast) - Recursive delegate resolution for complete chain validation Closes #440 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Changed minRuntimeVersion from optional to required in Expert interface - Added default value "v1.0" in schema - Updated all test files and helper functions to include minRuntimeVersion Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtimeVersion: RuntimeVersionto Job schema to track which runtime version executed the jobminRuntimeVersion?: RuntimeVersionto Expert schema for compatibility requirementsTest plan
runtime-version.ts(26 tests covering parsing, comparison, validation)setup-experts.ts(8 tests including 3-level chain, circular reference, diamond pattern)e2e/experts/runtime-version.tomle2e/perstack-runtime/runtime-version.test.tspnpm typecheckpassespnpm format-and-lintpassespnpm testpasses (1369 tests)pnpm buildsucceedsCloses #440
🤖 Generated with Claude Code