Fix: Use setting.runId for continued checkpoints#447
Merged
Conversation
When continuing a job, createNextStepCheckpoint was spreading the previous checkpoint's runId. This caused checkpoints to be created with wrong runId when the previous checkpoint had incorrect runId. Changes: - Added runId parameter to createNextStepCheckpoint - Pass setting.runId when creating next step checkpoint on continue - Updated tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createNextStepCheckpointto acceptrunIdas a parametersetting.runIdwhen creating next step checkpoint on continueProblem
When continuing a job,
createNextStepCheckpointspread the previous checkpoint's runId. If the previous checkpoint had incorrect runId (e.g., from a bug in wintermute'sget-run-params.ts), the new checkpoint would also have the wrong runId, causing duplicate key constraint violations.Test plan
createNextStepCheckpointtests pass🤖 Generated with Claude Code