Fix: restore tsdown bundling and fix workspace:* in published packages#616
Merged
Fix: restore tsdown bundling and fix workspace:* in published packages#616
Conversation
After the bun migration (PR #599), published packages had literal "workspace:*" in dependencies because changeset publish (npm publish) does not resolve workspace protocol like pnpm did. Additionally, private devDependencies were no longer bundled into dist since tsc replaced tsdown. Changes: - Restore tsdown as the build tool for all packages - Fix workspace:* to fixed versions in published packages' dependencies - Make @perstack/skill-manager private (was incorrectly public) - Move skill-manager to runtime's devDependencies (bundled by tsdown) - Add skill-manager's transitive public deps to runtime's dependencies Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…packages Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the bun migration (PR #599), two critical publishing issues emerged:
workspace:*not resolved:changeset publish(npm publish) does not resolveworkspace:*protocol like pnpm did. Published packages like@perstack/runtime@0.0.114+had literal"workspace:*"in dependencies, making them uninstallable by consumers.Private deps not bundled: tsdown previously bundled
devDependenciesinto dist. With tsc (no bundling), published packages referenced private modules that don't exist on npm.Changes
workspace:*with fixed versions in published packages'dependencies@perstack/skill-managerprivate (was incorrectly public — depends on private@perstack/perstack-toml)@perstack/skill-managerto runtime'sdevDependencies(bundled by tsdown)@perstack/base,@modelcontextprotocol/sdk,smol-toml) to runtime'sdependenciestsdown.config.tstotsconfig.jsonexcludes for packages with local configs"type": "module"to rootpackage.jsonto suppress Node.js warningsVerification
bun run build— all 23 packages build successfullybun run test— all 19 test suites passbun run typecheck— all 23 packages passworkspace:*in any published package'sdependenciesSkillManageris bundled into runtime's dist (confirmed via grep)Test plan
bun run buildpassesbun run testpassesbun run typecheckpassesbun run format-and-lint— no errors (existing warnings only)npm pack --dry-runon runtime/react/base shows correct package contents🤖 Generated with Claude Code