Refactor: Remove dead code from file tool handling#68
Merged
Conversation
- Delete resolving-pdf-file.ts and resolving-image-file.ts - Remove ResolvingPdfFile/ResolvingImageFile states from state machine - Remove resolvePdfFile/resolveImageFile events from @perstack/core - Remove dead cases from TUI/CLI event handlers - Update README.md state machine diagram
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
FL4TLiN3
force-pushed
the
refactor/remove-dead-file-tool-code
branch
from
3d263fd to
7e58a6b
Compare
Verify that readPdfFile and readImageFile correctly process files by having experts summarize/describe the content.
FL4TLiN3
force-pushed
the
refactor/remove-dead-file-tool-code
branch
from
7e58a6b to
de89615
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead code that was left after PR #62 consolidated file tool handling into
calling-tool.ts.Changes
Removed Files
resolving-pdf-file.tsand its testresolving-image-file.tsand its testRemoved from State Machine
ResolvingPdfFilestateResolvingImageFilestateresolvePdfFileevent handlerresolveImageFileevent handlerRemoved from @perstack/core
resolvePdfFileevent type and factoryresolveImageFileevent type and factoryUpdated
Testing
Closes #66
Note
Removes legacy PDF/image resolve events and states from core/runtime, updates TUI and docs accordingly, and adds multi-modal E2E tests with expert configs and fixtures.
resolvePdfFile/resolveImageFileevents and factories frompackages/core/src/schemas/runtime.ts.packages/runtime/src/runtime-state-machine.tsby deletingResolvingPdfFile/ResolvingImageFilestates and related transitions.packages/runtime/src/states/resolving-pdf-file.ts,resolving-pdf-file.test.ts,resolving-image-file.ts,resolving-image-file.test.ts.packages/perstack/src/lib/tui.tsxandpackages/tui/src/hooks/state/use-step-store.ts.packages/runtime/README.md(remove PDF/image resolve paths).e2e/multi-modal.test.tsand expert confige2e/experts/multi-modal.tomlwith fixtures (e2e/fixtures/test.pdf,test.gif).e2e/README.mdwith new test files/categories and manual verification notes..changeset/twenty-dragons-kick.md.Written by Cursor Bugbot for commit 5b75308. This will update automatically on new commits. Configure here.