Fix: Handle file read errors gracefully in resolving file states#7
Merged
Fix: Handle file read errors gracefully in resolving file states#7
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
efcc1a4 to
a609100
Compare
Merged
This was referenced Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
Gracefully handles file read failures in PDF/image resolving states, adds unit tests for error paths, and updates review report/changeset.
readFileinpackages/runtime/src/states/resolving-pdf-file.tsandresolving-image-file.ts, returningtextParterrors instead of crashing.resolving-pdf-file.test.tsandresolving-image-file.test.tsto mockreadFile, validate base64 success paths, and add error-handling cases.CODE_REVIEW_REPORT.mdto mark file operation handling as fixed and add commit796f981.@perstack/runtimepatch.Written by Cursor Bugbot for commit a609100. This will update automatically on new commits. Configure here.