refactor: split InstructionMessage into multiple system message blocks#707
Merged
refactor: split InstructionMessage into multiple system message blocks#707
Conversation
Split the single concatenated instruction string into 2-3 separate SystemModelMessages for improved prompt clarity and per-block cache control. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tents Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createInstructionMessageinto 2-3 separateTextParts (preamble+meta, expert instruction, optional skill rules) instead of one concatenated string with---separatorsmessageToCoreMessageto returnModelMessage[], mapping each instructionTextPartto a separateSystemModelMessagecacheControlonly to the last system block for optimal prefix cachinggenerating-tool-call.tsto useflatMapfor the new array return typeinstructionContentsToCoreContenthelperTest plan
bun run typecheck— 24/24 packages passbun run test— message tests 18/18 pass (pre-existing failures in coordinator/setup-experts unrelated)bun run build— 24/24 packages passbun run validate:changeset🤖 Generated with Claude Code