Eliminate warning from division by zero#51
Merged
hurricane642 merged 2 commits intomainfrom Nov 4, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we eliminate a possible warning caused by division by zero. Previously, we only handled the
ZeroDivisionErrorerror, but when we vectorize the function,numpyreturns Warning instead of this error, so this case was not handled at all. Now we have set up a rather simple if, which checks the value of the number we plan to divide by. If it is less than1e-20, we just returninf.Thanks to @pinkston3 for catching this problem!