Compare "Inf" and "Infinity" as equal#55
Merged
alex2shiyu merged 1 commit intoperturbo-code:mainfrom Jan 4, 2024
pinkston3:inf-values
Merged
Compare "Inf" and "Infinity" as equal#55alex2shiyu merged 1 commit intoperturbo-code:mainfrom pinkston3:inf-values
alex2shiyu merged 1 commit intoperturbo-code:mainfrom
pinkston3:inf-values
Conversation
The nvfortran compiler outputs "Inf" for infinity values, and other compilers output "Infinity". This fix chops off the "inity" part of "Infinity" to ensure they all "look the same" to the test code.
Contributor
Author
|
My one concern about this edit is that we may want to retain the original string values for error reporting, rather than the normalized ones. Thoughts? |
imaliyov
approved these changes
Dec 20, 2023
Member
|
I think this fix would work fine! If we have 'inf' or 'infinity', this is enough information to understand what's going on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nvfortran compiler outputs "Inf" for infinity values, and other compilers output "Infinity". This fix chops off the "inity" part of "Infinity" to ensure they all "look the same" to the test code.