Skip to content

Add functionality for the gpu testing#65

Merged
hurricane642 merged 2 commits intomainfrom
gpu_tests
Nov 8, 2024
Merged

Add functionality for the gpu testing#65
hurricane642 merged 2 commits intomainfrom
gpu_tests

Conversation

@hurricane642
Copy link
Copy Markdown
Collaborator

Hello everyone,
In this PR, we add functionality for testing gpu-version of Perturbo.
Main changes:

  1. Additional command line --arch (by default equal to cpu). Characterize the type of architecture that user want to check;
  2. After this PR, in the test_listing.yml you should have architecture as a tag of the test, otherwise it will be ignored;
  3. Choice of the test by the argument arch is going on the step of filtering, along with the filtering by tags and names.

Let me know what do you think!

@hurricane642 hurricane642 added the enhancement New feature or request label Oct 29, 2024
@hurricane642 hurricane642 self-assigned this Oct 29, 2024
@alex2shiyu
Copy link
Copy Markdown
Collaborator

I have used this one to test my GPU branch. It's fantastic!
Cause we do not have a test suite for perturbopy and I did not find any bugs during my usage, I will approve this feature.

@hurricane642
Copy link
Copy Markdown
Collaborator Author

I have used this one to test my GPU branch. It's fantastic! Cause we do not have a test suite for perturbopy and I did not find any bugs during my usage, I will approve this feature.

Cool, thank you a lot! I'll make related updates in the perturbo repo and merge PR!

@hurricane642 hurricane642 merged commit b46750e into main Nov 8, 2024
@hurricane642 hurricane642 deleted the gpu_tests branch November 8, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants