Conversation
hurricane642
requested changes
Dec 10, 2024
Collaborator
hurricane642
left a comment
hurricane642
left a comment
There was a problem hiding this comment.
Looks great! Just cosmetic comments
…lso removed empty code block.
Contributor
Author
|
@hurricane642 Thank you for your comments! I made all of the changes you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added tutorials for the postprocessing scripts for the new spin calc modes (ephmat_spin, imsigma_spin, and spins).
Since the ephmat_spin and imsigma_spin calc modes have the same attributes and functions as their non-spin counterparts (only the class name is different), I made tutorials on how to access the data. I referenced the ephmat tutorial for plotting in my ephmat_spin tutorial.
For the spins tutorial, I detailed how to access the data and use the plotting features with or without the LogNorm.
Also, while making these tutorials, I found a small bug on my imsigma_spin.py plotting script and corrected it.