New-Fixture throws when $pwd is used as -parth argument

Hi!

I came across some minor "bug" when using $pwd or $(pwd) directly as -Path argument:
New-Fixture -Path $pwd
New-Fixture -Path $(pwd)

[W0216 12:44:14 C:\Temp]> New-Fixture -path $Pwd -name "Out-Log"
Method invocation failed because [System.Management.Automation.PathInfo] doesn't contain a method named 'TrimStart'.
At C:\Users\michael.kargl\Documents\WindowsPowerShell\Modules\Pester\Pester.psm1:197 char:9

•     $path = $path.TrimStart(".")
  

•     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidOperation: (:) [], RuntimeException
  • FullyQualifiedErrorId : MethodNotFound

Method invocation failed because [System.Management.Automation.PathInfo] doesn't contain a method named 'TrimStart'.
At C:\Users\michael.kargl\Documents\WindowsPowerShell\Modules\Pester\Pester.psm1:198 char:9

•     $path = $path.TrimStart("\")
  

•     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidOperation: (:) [], RuntimeException
  • FullyQualifiedErrorId : MethodNotFound

Method invocation failed because [System.Management.Automation.PathInfo] doesn't contain a method named 'TrimStart'.
At C:\Users\michael.kargl\Documents\WindowsPowerShell\Modules\Pester\Pester.psm1:199 char:9

•     $path = $path.TrimStart("/")
  

•     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

  • CategoryInfo : InvalidOperation: (:) [], RuntimeException
  • FullyQualifiedErrorId : MethodNotFound

New-Fixture -Path "$pwd"
works just fine.

The reason is because of powershell's dynamic typing:
$PWD stores the value of $(pwd) which is a System.Management.Automation.PathInfo Object.

Possible fix:
Changing the New-Fixture Param section to:
param(
[string] $path,
[string] $name
)

This way only strings would be allowed as path and fix the minor bug.

[scottmuc]

Thanks for the report, and the fix! Want to take a crack at submitting a PR for this?

Hi,

Yeah, sure thing ;)
I'll submit it tomorrow!

On 03.03.2014, at 19:13, "Scott Muc" notifications@github.com wrote:

Thanks for the report, and the fix! Want to take a crack at submitting a PR for this?

�
Reply to this email directly or view it on GitHub.

[nohwnd]

Hey mate, I see you are referencing this bug from your repo and you are committing directly to your master. If you create the PR (pull request) from your master to Pester/master and make any further changes (play with your fork of Pester) all the published commits to your master will propagate to the PR. Just a heads up .) The same happened to me when making my first PR.

Better way is to create a branch (e.g. "FixPath") and commit the changes to it. Do not Publish (push) the changes. Then right before you create the PR you synchronize your fork's master with the Pester/master and rebase your branch on your master ( squashing all the commits into one). Run all Pester tests to validate your changes. Then you publish the branch and create the PR to Pester/master. It may sound complicated but in reality it is pretty simple. :) We can get in touch and I can show you if you are interested.

Thanks for the warning!
Wow that really seems to be a ton of work!

Would be nice if we could work through that. I have to admit.. Up until now I haven't had the chance to work, with multiple people, on the same project.

I have created a branch for this change though (New-Fixture-Fix-ExceptionWhenUsingPwd) and merged it right back into master before pushing it to github. When creating the PR I used this branch.. It seemed the appropriate thing to do.

[scottmuc]

Thanks for that @nohwnd. @Numn once you get familiar with git, it becomes quite mechanical and easy. It does take a while to form the habit though. It wasn't until I worked with git and a multi-person team that I really understood git. Git is difficult, there's no denying that. I hope this PR exercise will help you expand your breadth of knowledge :)

Pester is missing a Contributing.md so I can't really complain too much about differing workflows. A good article on this subject is: https://gun.io/blog/how-to-github-fork-branch-and-pull-request/

[nohwnd]

@Numn Send me your contact information to me@jakubjares.com. I prefer gTalk (Hangouts) for instant messaging.

[nohwnd]

fixed in edad2eb